Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the examples of cX.count operations to make them easier to understand. #5658

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

lybCNU
Copy link
Contributor

@lybCNU lybCNU commented Dec 19, 2024

Updated the examples of cX.count operations to make them easier to understand.

Updated the examples of `cX.count` operations to make them easier to understand.
@lybCNU lybCNU requested a review from a team as a code owner December 19, 2024 02:12
@bgruening
Copy link
Member

@lybCNU the title and the content does not fit together. The changes also do not look correct. We really wanted to search for "December". Can you elaborate a bit?

@shiltemann
Copy link
Member

shiltemann commented Jan 13, 2025

@bgruening I'm guessing the point is that we are currently using the count() function as a contains(), and @lybCNU wanted to show an example where we actually set a higher count. I'm just not sure that the birthday column is the best for that.

@lybCNU I would suggest leaving the current question as it is, and simply adding a second question/exercise to the box. Then people will have 2 examples to fully understand the c5.count() function.

And maybe instead of the December/September example, how about finding out how many athletes have a 3-part name, i.e. by counting spaces in that column with c2.count(' ') == 2? (and bonus question could be finding the athletes with the most-part names by increasing this number, e.g. you can go up to 5 and find several athletes with 6-part names, e.g. "Patricia Galvin de la Tour d'Auvergne")

What do you think?

@lybCNU
Copy link
Contributor Author

lybCNU commented Jan 13, 2025

@bgruening @shiltemann

Apologies for the delayed response, as it’s been a busy end-of-semester period. Thank you both for your valuable feedback and suggestions!

During this semester, I noticed that quite a few students found the use of cX.count() confusing, likely because the original example didn’t fully demonstrate the function’s purpose. This led me to consider replacing it with a more suitable example, which is why I initially proposed the “December/September” scenario to illustrate setting a higher count. However, I realize that this example might not be the best fit.

I really appreciate @shiltemann’s suggestion! Adding a second question or exercise alongside the current one sounds like a great way to help clarify cX.count() for students. The example of counting spaces in names to identify athletes with three-part names, as well as a bonus challenge to find those with the longest names, seems both practical and engaging for students.

I’ll update the exercises accordingly. Thanks again for your thoughtful suggestions and support!

@bgruening
Copy link
Member

Sounds great to me! :) Nice!

Added examples for filtering names and longer names. Retained December example.
@lybCNU
Copy link
Contributor Author

lybCNU commented Jan 16, 2025

Hi, @bgruening @shiltemann

I have made the updates to the exercises as discussed. Could you please review them when you have a chance?

Thank you!

@shiltemann
Copy link
Member

shiltemann commented Jan 16, 2025

Thanks a lot @lybCNU! Looking at the question again in context, I agree that it is perhaps clearer to remove the December example (since we used find() already before which would be the obvious method to solve that question). So I removed that and instead I have added a couple more counting questions/exercises based on the names. And just some minor formatting changes

shiltemann
shiltemann previously approved these changes Jan 16, 2025
@shiltemann shiltemann enabled auto-merge January 16, 2025 15:57
@shiltemann shiltemann merged commit 9d0bd87 into galaxyproject:main Jan 16, 2025
3 checks passed
@lybCNU lybCNU deleted the patch-1 branch January 17, 2025 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants